build: upgrade magic-string to 1.0.0 and update import syntax#3858
Merged
Conversation
angular-robot
Bot
added
the
area: build & ci
clydin
approved these changes
Jul 20, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the import of magic-string in rollup.config.js to use destructuring. However, the reviewer correctly identified that this change will lead to a runtime TypeError because magic-string exports its main class as the default export in CommonJS, meaning MagicString would be undefined. The reviewer provided an actionable suggestion to destructure the default export and alias it to MagicString instead.
alan-agius4
force-pushed
the
update-magic-string
branch
from
July 20, 2026 14:14
9769ed5 to
b04477a
Compare
Update magic-string to latest.
alan-agius4
force-pushed
the
update-magic-string
branch
from
July 20, 2026 14:15
b04477a to
7ee178c
Compare
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update magic-string to latest.