Repository navigation
fix(docs): fail the build if generated HTML cannot be written - #1941
Open
nemo-crypto wants to merge 1 commit into
Open
nemo-crypto wants to merge 1 commit into
nemo-crypto wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs generator prints a success message and exits zero even when it cannot write
docs/index.html. Let the write error terminate the build so CI can detect it.Verification
In a scratch checkout with dependencies installed, make
docs/index.htmla directory and runnpm run docs:pages. The current generator logs success and exits zero. With this change it reportsEISDIRand exits nonzero. With a writable destination, both versions generate byte-identical HTML.This is a Node build change, so the command above demonstrates it directly.