Skip to content

fix(docs): fail the build if generated HTML cannot be written - #1941

Open
nemo-crypto wants to merge 1 commit into
animate-css:mainfrom
nemo-crypto:fix/docs-build-write-failure
Open

nemo-crypto wants to merge 1 commit into
animate-css:mainfrom
nemo-crypto:fix/docs-build-write-failure

Conversation

@nemo-crypto

Copy link
Copy Markdown

Summary

The docs generator prints a success message and exits zero even when it cannot write docs/index.html. Let the write error terminate the build so CI can detect it.

Verification

In a scratch checkout with dependencies installed, make docs/index.html a directory and run npm run docs:pages. The current generator logs success and exits zero. With this change it reports EISDIR and exits nonzero. With a writable destination, both versions generate byte-identical HTML.

This is a Node build change, so the command above demonstrates it directly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants