feat(opencode): run bash commands in background#33310
Open
Rejudge-F wants to merge 2 commits into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR Found:
Please review PR #32675 to confirm whether it's a duplicate or addresses the same underlying feature request. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #1970
Type of change
What does this PR do?
Adds an explicit opt-in background mode for the opencode bash tool.
When the model calls bash with
run_in_background: true(or thebackgroundalias), the command is registered with the existingBackgroundJobservice and the tool returns immediately with a job id and output path. The command keeps running outside the original tool call, writes its final output to the output path, and injects a synthetic completion message back into the parent session when it exits.This also adds
bash_killso agents can cancel bash background jobs by id. It checks the job type before canceling so it cannot stop non-bash background jobs such as subagent tasks.This is intentionally narrower than a full shell job manager: it does not add mid-flight detach, automatic backgrounding, or a TUI keybind.
How did you verify your code works?
cd packages/opencode && bun typecheckcd packages/opencode && bun test test/tool/shell.test.ts test/tool/parameters.test.tscd packages/opencode && bun test test/tool/ --timeout 60000bun run typecheckbun run lint— 0 errors, existing warnings onlyScreenshots / recordings
N/A
Checklist