fix(mcp): preserve server additionalProperties in convertTool#33327
Open
MeloMei wants to merge 1 commit into
Open
fix(mcp): preserve server additionalProperties in convertTool#33327MeloMei wants to merge 1 commit into
MeloMei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33322
Type of change
What does this PR do?
In
catalog.tsconvertTool,additionalPropertiesis hardcoded tofalseafter spreading the MCP server's input schema. This discards whatever the server declared — breaking tools that useadditionalProperties: trueor an object sub-schema.The fix preserves the server's original value and only defaults to
falsewhen the server omits it:How did you verify your code works?
Added unit tests in
test/mcp/catalog.test.tscovering all four cases: server omits additionalProperties (defaults to false), server sets true, server sets an object sub-schema, and server explicitly sets false. All 64 MCP tests pass.Screenshots / recordings
N/A — no UI changes.
Checklist