fix(tui): preserve worker rejection handling#33448
Open
rekram1-node wants to merge 1 commit into
Open
Conversation
24a1e56 to
213d405
Compare
3aef0aa to
f984c31
Compare
f984c31 to
4be4dbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unhandledRejectionlistener removed during the Effect logging migrationContext
After the listener was removed in
c06ad7c88, an unhandled rejection in an async worker callback can terminate the backend worker. Subsequent TUI requests then surface onlyWorker has been terminated, hiding the original rejection.A reported original rejection is:
This indicates a separate stream teardown race. This PR restores rejection containment and observability; it does not claim to fix that underlying stream lifecycle bug.
Closes #33269
Closes #32694
Verification
bun typecheckfrompackages/opencodegit diff --check