fix(provider): default custom models to image input#33453
Open
rekram1-node wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelV2.Info.empty()capabilities and document the temporary config-plugin default boundaryIssues
Fixes #20802
Fixes #30071
Addresses the image-input portion of #22673.
Same root cause / historical reports:
Also addresses the custom-model image-default symptoms reported in these broader or mixed issues:
Related modalities discoverability reports: #9897 and #25229. This PR removes the need to specify image modalities for the default custom-model case, but does not add documentation for explicit modality overrides.
Not covered here: terminal clipboard extraction, TUI drag-and-drop, Read/MCP tool-result media handling, PDFs, malformed
image_urlpayloads, provider-side image errors, or genuinely text-only models.Test plan
bun test test/config/config.test.ts test/config/provider.test.ts test/model.test.tsinpackages/corebun test test/provider/provider.test.tsinpackages/opencodebun typecheckinpackages/corebun typecheckinpackages/opencodegit diff --check