feat(core): manage session websocket channels - #41564
Open
nexxeln wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A
Type of change
What does this PR do?
Adds a Location-scoped Session WebSocket manager for OpenAI Responses. It reuses one physical connection per Session, serializes same-Session exchanges, isolates different Sessions, rotates on connection age or handshake-affinity changes, and closes poisoned or interrupted connections.
Only provably not-sent failures can use the existing HTTP fallback. Ambiguous sends are never replayed. Bounded reader queues poison instead of dropping frames, and Session move/delete plus Location shutdown close owned sockets. Node uses the header-capable
wsconstructor.Execution is disabled by default and requires
OPENCODE_EXPERIMENTAL_OPENAI_RESPONSES_WEBSOCKET=true, provideropenai, routeopenai-responses, and no active Session HTTP middleware. This PR does not addprevious_response_idcontinuation.How did you verify your code works?
cd packages/core && bun typecheckcd packages/core && bun test test/session-model-transport.test.ts test/session-runner.test.ts test/session-execution.test.ts test/location-layer.test.ts test/session-remove.test.tscd packages/ai && bun typecheck && bun run build && bun test test/executor.test.tsbun typecheckfrom the workspace rootScreenshots / recordings
N/A
Checklist