fix(tui): support single categorical theme hue - #41570
Open
opencode-agent[bot] wants to merge 1 commit into
Open
fix(tui): support single categorical theme hue#41570opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This surfaced when Alan switched to a custom theme he had made. The custom theme was valid: the theme schema accepts one or more categorical hues. The TUI syntax generator incorrectly assumed every theme supplied at least two and crashed while reading the missing second hue. Because the selected theme is persisted in the client config, restarting or stopping the background service did not recover the TUI.
Closes #41569
Testing
bun test test/theme/v2/syntax.test.tsbun test test/theme/v2 test/theme.test.tsbun run typecheckinpackages/themebun run typecheckinpackages/tuiRequested by: @kitlangton (Kit via Slack)