Skip to content

fix(tui): scope attention notifications - #41601

Open
opencode-agent[bot] wants to merge 1 commit into
devfrom
notification-scope
Open

fix(tui): scope attention notifications#41601
opencode-agent[bot] wants to merge 1 commit into
devfrom
notification-scope

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • expose the directory/workspace metadata already supplied by the TUI event adapter in the plugin event-bus type
  • ignore question, permission, status, and error events that do not belong to the event session location
  • notify for permission and question requests only when they remain pending in TUI state, so auto-approved permissions do not play attention sounds

Why

The server event feed spans locations, while the built-in notification plugin previously consumed matching event names without checking their directory or workspace. Auto-approve mode also replies to permission.asked without adding the request to pending TUI state, but the notification plugin still played staplebops-06 for the transient event.

Testing

  • bun test test/cli/cmd/tui --timeout 30000 --only-failures (25 passed)
  • bun typecheck in packages/tui
  • bun typecheck in packages/plugin
  • Prettier check for changed files
  • git diff --check

Requested by: @kommander (Sebastian Herrlinger via Slack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant