fix(tui): isolate tool stdin - #41613
Open
mathew-cf wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found The search found PR #34242 which is a related prior work that this PR explicitly builds upon (as mentioned in the description), but no duplicate or conflicting PRs addressing the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41612
Type of change
What does this PR do?
The TUI now reads from a dedicated controlling-terminal stream while fd 0 is redirected to the platform null device. Tool implementations and their subprocesses therefore receive EOF instead of competing with the TUI for keystrokes. The dedicated stream is also used by external editors and Windows console-mode handling.
This builds on the dedicated TUI input-stream work in #34242 by @LordMikkel and extends it to isolate tool subprocess stdin.
How did you verify your code works?
packages/opencodeandpackages/tuipackages/opencode/test/cli/runsuitepackages/tuisuiteScreenshots / recordings
Not applicable; this fixes terminal input ownership without changing the rendered UI.
Checklist