refactor(core): skill service stores values, config plugin owns the filesystem - #41622
Merged
Conversation
kitlangton
marked this pull request as ready for review
August 11, 2026 00:02
kitlangton
force-pushed
the
refactor/skill-service-values
branch
from
August 11, 2026 00:17
fe7c2c0 to
c763eec
Compare
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skill.Infovalues.ConfigSkillPlugin.Why
Core services should not be filesystem-aware. Embedded and SDK-registered skills are now the normal value-registration path rather than a special source variant, and the skill service drops four infrastructure dependencies to one (
Bus.node).How
Source[]to an ID-keyedInforegistry.draft.sourcewithlist/add/update/remove;addupserts by ID and later transforms win.ConfigSkillPlugin.config.updated, preserving the previous coarse invalidation granularity.Skill.Service.reload()re-runs registered transforms against current values; filesystem rescanning is owned byConfigSkillPluginthrough watchers andconfig.updated.SkillFile.parsehelper and debug-logs skipped files with a markdown/frontmatter reason plus schema issue details when available.Testing
bunx tsgo --noEmitinpackages/coreandpackages/plugin.bunx tsgo -b tsconfig.json tsconfig.tests.jsoninpackages/core.bun turbo typecheck --concurrency=3: 33 packages passed.@opencode-ai/util:buildfailure did not recur.PluginSupervisor config > logs invalid packages and continues loadingbecause two user-configured plugins appeared in its exact-list assertion.Findings
Skill.sources()had no server route, protocol, client, or TUI consumers; only tests used it, so it was removed without retaining a compatibility surface.Skill.Sourceremains in@opencode-ai/schemafor config parsing.FSUtil, but notWatcher.ServiceorSkillDiscovery.Service. Both are now provided byPluginInternal.services;SkillDiscovery.nodewas added to the supervisor graph, whileWatcher.nodewas already a supervisor dependency.