Repository navigation
feat(core): run local Windows shell commands in the process daemon - #63409
Conversation
User decisions: - Use @opencode/pty 0.5.2 for local Windows shell commands. - Preserve remote and fallback execution without feature negotiation or a protocol bump. - Exercise Windows shell handoff and interruption in the integration tests.
There was a problem hiding this comment.
I found no blocking concerns, but couldn't verify it here: the change only affects Windows and this environment is Linux. The source change is one condition in shell.ts. Remote workspaces and an unavailable daemon still fall back to the spawner, a RequestError still fails the call without spawning again, and the 0.5.0 → 0.5.2 pin is updated everywhere. On Linux, the five focused core suites pass (162 passed, 0 failed), including against the real 0.5.2 daemon, and the server's persistent-pty tests pass. Windows behaviour, such as PowerShell output, the immediate termination on SIGTERM and recovery after a restart, depends on the Windows CI run, which was still in progress when I checked.
Public API: unchanged. The @opencode/pty dependency moves 0.5.0 → 0.5.2, and the protocol is already v8 on dev.
Related: #56804
|
Windows unit tests passed on b516bfc (core: 6,353 passed, 1,113 skipped, 0 failed), as did the Windows build, app-1, and both component suites. The full run is red on Windows app-2 and Linux app-2. All five reported Windows failures in timeline-geometry/timeline-stream also appear in this earlier dev run. |
Issue for this PR
Follows #62978 and #63381.
Type of change
What does this PR do?
Local Windows shell commands can now survive a server restart. Core, CLI and server pin the pipe-capable daemon at 0.5.2 and use the existing local daemon path on Windows. Remote workspaces and unavailable daemons retain their spawner. Protocol v8; no feature flag.
How did you verify your code works?
Frozen install, core typecheck, and five focused core suites on Linux (162 passed). The Windows fixtures cover PowerShell output, foreground-to-background handoff, restart recovery and interrupted calls. Full CI on the branch commit, including Windows.
Screenshots / recordings
N/A
Checklist
Added by the opencode bot (AI-generated).
Related: #56804