Skip to content

feat(core): run local Windows shell commands in the process daemon - #63409

Merged
jlongster merged 1 commit into
devfrom
windows-shell-daemon
Nov 11, 2026
Merged

jlongster merged 1 commit into
devfrom
windows-shell-daemon

Conversation

@jlongster

@jlongster jlongster commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Issue for this PR

Follows #62978 and #63381.

Type of change

  • New feature

What does this PR do?

Local Windows shell commands can now survive a server restart. Core, CLI and server pin the pipe-capable daemon at 0.5.2 and use the existing local daemon path on Windows. Remote workspaces and unavailable daemons retain their spawner. Protocol v8; no feature flag.

How did you verify your code works?

Frozen install, core typecheck, and five focused core suites on Linux (162 passed). The Windows fixtures cover PowerShell output, foreground-to-background handoff, restart recovery and interrupted calls. Full CI on the branch commit, including Windows.

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Added by the opencode bot (AI-generated).

Related: #56804

User decisions:
- Use @opencode/pty 0.5.2 for local Windows shell commands.
- Preserve remote and fallback execution without feature negotiation or a protocol bump.
- Exercise Windows shell handoff and interruption in the integration tests.

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no blocking concerns, but couldn't verify it here: the change only affects Windows and this environment is Linux. The source change is one condition in shell.ts. Remote workspaces and an unavailable daemon still fall back to the spawner, a RequestError still fails the call without spawning again, and the 0.5.0 → 0.5.2 pin is updated everywhere. On Linux, the five focused core suites pass (162 passed, 0 failed), including against the real 0.5.2 daemon, and the server's persistent-pty tests pass. Windows behaviour, such as PowerShell output, the immediate termination on SIGTERM and recovery after a restart, depends on the Windows CI run, which was still in progress when I checked.

Public API: unchanged. The @opencode/pty dependency moves 0.5.0 → 0.5.2, and the protocol is already v8 on dev.

Related: #56804

@jlongster

Copy link
Copy Markdown
Contributor Author

Windows unit tests passed on b516bfc (core: 6,353 passed, 1,113 skipped, 0 failed), as did the Windows build, app-1, and both component suites. The full run is red on Windows app-2 and Linux app-2. All five reported Windows failures in timeline-geometry/timeline-stream also appear in this earlier dev run.

@jlongster
jlongster merged commit 63dd3f1 into dev Nov 11, 2026
24 of 28 checks passed
@jlongster
jlongster deleted the windows-shell-daemon branch November 11, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant