fix(client): remove unsafe __del__ method from AsyncHttpxClientWrapper - #1798
Open
vjaudir8123-debug wants to merge 1 commit into
Open
fix(client): remove unsafe __del__ method from AsyncHttpxClientWrapper#1798vjaudir8123-debug wants to merge 1 commit into
__del__ method from AsyncHttpxClientWrapper#1798vjaudir8123-debug wants to merge 1 commit into
Conversation
The `__del__` method was attempting to close the client by calling `asyncio.get_running_loop().create_task(self.aclose())`. Since garbage collection can run on any thread at any time, this could trigger in a background thread without an event loop (swallowing a `RuntimeError` and leaking the connection) or, if it did find a loop, it was thread-unsafe and could corrupt the asyncio loop. The connection must be explicitly managed by the consumer. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
__del__method inAsyncHttpxClientWrapperwas attempting to close the client by callingasyncio.get_running_loop().create_task(self.aclose()).Since garbage collection can run on any thread at any time, this approach is fundamentally unsafe in Python asyncio:
RuntimeError(which is swallowed) and leaks the connection without warning.create_taskis thread-unsafe and can corrupt the entire async loop.This PR removes the unsafe
__del__method. The connection lifecycle should be managed explicitly by the consumer (viaasync withor explicit.close()).