fix(parse): reject unrepresentable dynamic object schemas - #1818
Open
uuzzrm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1817.
When an object schema uses
patternProperties,propertyNames, orunevaluatedPropertieswithout explicitproperties, the structured-output schema transformer previously discarded the dynamic-key rule and emitted an object with no properties andadditionalProperties: false. That silently made every non-empty value invalid.This change raises a clear
ValueErrorfor those unrepresentable shapes instead of sending an unsatisfiable schema. Objects that already have explicitpropertieskeep their existing behavior; unsupported dynamic-key constraints remain in the description as before.Tests
UV_PYTHON='>=3.9,<3.10' ./scripts/test tests/lib/_parse/test_transform.pyUV_PYTHON='>=3.10,<3.11' ./scripts/test tests/lib/_parse/test_transform.pyuv run pyright src/anthropic/lib/_parse/_transform.py: 0 errorsuv run ruff check src/anthropic/lib/_parse/_transform.py tests/lib/_parse/test_transform.py: passeduv run ruff format --check src/anthropic/lib/_parse/_transform.py tests/lib/_parse/test_transform.py: passed