Refactoring minicluster files to remove 1 TODO

[Amemeda]

Removing # TODO: these minicluster classes should be moved into the correct package for the module from line 59 of check-module-packaging-conventions.sh, this pr will clear all TODO's from the shell script.

SHELVING FOR NOW

• Group of cluster files have been refactored into server.base.src.main.java.org.apache.accumulo.server.cluster
• this introduced import errors with untouched files SetGoalState.java and ServerType.java
• stuck on potential circular dependency issue when trying to resolve the import errors
• failing ITs also need to be fixed

[Amemeda]

This resolves the final TODO from #2699

[ctubbsii]

The weird thing about these ones is that these classes are supposed to represent a generic cluster, not specifically a minicluster (which is one specific instance of a cluster). So, I'm not sure it makes sense to move them into the minicluster package (which is listed as public API). If possible, it might make sense to move them into the server base jar instead of the minicluster jar, with a package name like org.apache.accumulo.server.cluster, that is not public API.

[Amemeda]

The weird thing about these ones is that these classes are supposed to represent a generic cluster, not specifically a minicluster (which is one specific instance of a cluster). So, I'm not sure it makes sense to move them into the minicluster package (which is listed as public API). If possible, it might make sense to move them into the server base jar instead of the minicluster jar, with a package name like org.apache.accumulo.server.cluster, that is not public API.

would the rest of the files in minicluster and miniclusterImpl have to move to the new package as well?

[ctubbsii]

would the rest of the files in minicluster and miniclusterImpl have to move to the new package as well?

No, the minicluster-specific implementations should stay associated with the minicluster package.