Track ZooKeeper property creation and modification times#6462
Open
DomGarguilo wants to merge 1 commit into
Open
Track ZooKeeper property creation and modification times#6462DomGarguilo wants to merge 1 commit into
DomGarguilo wants to merge 1 commit into
Conversation
Member
Author
|
Before merging, I want to discuss the trade off of storing this extra metadata in zookeeper. While it can be helpful to see the create and edit timestamps for individual props, we have to assess whether its worth the increased amount of data written in zookeeper per prop. The props blob is gzip compressed so things should compress reasonably well but we are still adding two extra timestamps per key. I do not have a great idea how much this will affect things in a real-world deployment so if anyone has an insights/opinions on things here that would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6254
createdandmodifiedmetadata toVersionedPropertieszk info-viewer --print-propsHere is some example output from running on a test table "ts_meta_test" with one custom prop set
accumulo zk info-viewer --print-props -t ts_meta_test:Here is some pasted lines from some more testing where you can see updating of the
createdandmodifiedtimes.in the shell I ran this:
and in between each step I printed the output:
You can see the initial set creates matching timestamps:
You can see adding a second property gives it its own timestamps:
You can see changing owner preserves created and updates modified:
You can see setting owner=domG again does not update modified:
You can see deleting table.custom.property removes it from the output: