Fix airflowctl backfill pause/unpause/cancel always failing with 405 - #73282
Merged
henry3260 merged 1 commit intoSep 17, 2026
Merged
Conversation
The API server registers these three backfill routes as PUT only, so every invocation was rejected before reaching the handler. The commands have never worked since the routes were introduced in the AIP-84 migration, which means an operator cannot stop a backfill that is consuming the cluster. The three tests covering them asserted only the request path, so the mock transport accepted any verb and kept the mismatch green all along.
Eason09053360
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
September 17, 2026 11:25
henry3260
approved these changes
Sep 17, 2026
Contributor
Backport failed to create: airflow-ctl/v0-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker c4ab0c3 airflow-ctl/v0-1-testThis should apply the commit to the airflow-ctl/v0-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
1 task
henry3260
added a commit
that referenced
this pull request
Sep 17, 2026
…always failing with 405 (#73282) (#73293) The API server registers these three backfill routes as PUT only, so every invocation was rejected before reaching the handler. The commands have never worked since the routes were introduced in the AIP-84 migration, which means an operator cannot stop a backfill that is consuming the cluster. The three tests covering them asserted only the request path, so the mock transport accepted any verb and kept the mismatch green all along. (cherry picked from commit c4ab0c3) Co-authored-by: Y-C <easoneason0905@gmail.com> Co-authored-by: Eason09053360 <185830721+Eason09053360@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
airflowctl backfill pause,unpauseandcancelhave never worked. The APIserver registers all three routes as
PUT(
airflow-core/src/airflow/api_fastapi/core_api/routes/public/backfills.py),but the client sends
POST, so the server answers405 Method Not Allowedandthe CLI raises instead of acting on the backfill. The routes have been
PUTsince they were introduced in the AIP-84 migration, so there is no server
version where
POSTworked.The practical impact is that an operator who needs to stop a runaway backfill
cannot do it from the CLI.
The mismatch stayed invisible because the three tests asserted only
request.url.path.httpx.MockTransporthas no route table, so it returned200for any verb.What
airflow-ctl/src/airflowctl/api/operations.py—BackfillOperations.pause,unpauseandcancelnow useclient.putinstead ofclient.post.airflow-ctl/tests/airflow_ctl/api/test_operations.py— addedassert request.method == "PUT"totest_pause,test_unpauseandtest_cancel, matching the eight existing method assertions elsewhere in thefile. Reverting the client change makes exactly these three tests fail.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines