Reject a DataSourceConfig with no uri or format in DataFusionEngine - #73287
Draft
pankajastro wants to merge 2 commits into
Draft
pankajastro wants to merge 2 commits into
pankajastro wants to merge 2 commits into
Conversation
LLMSchemaCompareOperator accepts a DataSourceConfig with only conn_id and table_name, introspected via DbApiHook instead of DataFusion, but construction failed for that shape. Also close a related gap in the same validation: an object-store DataSourceConfig with storage_type set but no uri. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
LLMSQLOperator, DataFusionToolset, and AnalyticsOperator hand DataFusionEngine.register_datasource whatever DataSourceConfig the caller supplies, unlike LLMSchemaCompareOperator which checks the connection kind first. A plain-database-table config reaching any of them failed deep inside credential resolution with a confusing "Unknown connection type" error instead of a clear message. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #73273 — the plain-database-table
DataSourceConfigshape this fixes doesn't exist until that merges. The diff below includes #73273's commit; check the "Commits" tab to see just this PR's own commit. Rebasing ontomainonce #73273 merges.Follow-up per review feedback on #73273.
LLMSQLOperator,DataFusionToolset, andAnalyticsOperatorhandDataFusionEngine.register_datasourcewhateverDataSourceConfigthe caller supplies, unlikeLLMSchemaCompareOperatorwhich checks the connection kind first. A plain-database-table config reaching any of them failed deep inside credential resolution with a confusingUnknown connection typeerror instead of a clear message.register_datasourcenow rejects that shape immediately.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5) following the guidelines