Add missing tests for sftp provider exceptions - #73289
Open
neochaotic wants to merge 1 commit into
Open
neochaotic wants to merge 1 commit into
neochaotic wants to merge 1 commit into
Conversation
The sftp provider's exceptions module had no dedicated test module and was not covered indirectly, so it was suppressed in the OVERLOOKED_TESTS allowlist. Cover the behaviour behind ConnectionNotOpenedException: the handle_connection_management decorator raises it when no managed connection is open, delegates when a connection already exists, and opens a managed connection when use_managed_conn is set. Also assert the exception derives from AirflowException, which callers catching the base class rely on. Remove the sftp entry from OVERLOOKED_TESTS accordingly. Closes: apache#72268
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sftpprovider'sexceptions.pyhad no dedicated test module and was not covered indirectly, so it sat on theOVERLOOKED_TESTSallowlist inairflow-core/tests/unit/always/test_project_structure.py. This is thesftp-scoped subset of #35442.The module defines a single exception,
ConnectionNotOpenedException, so the useful scope is the behaviour that raises it — thehandle_connection_managementdecorator inhooks/sftp.py, whose branches were uncovered as well. New tests drive the decorator against a small stub hook (no SFTP server needed) and assert:ConnectionNotOpenedException, and the message points the caller athook.get_managed_conn();use_managed_conn=True) opens a managed connection and makes it current on the hook instead of raising;ConnectionNotOpenedExceptionderives fromAirflowException— callers catching the base class rely on that, so narrowing it later would be a breaking change.The
sftpentry is removed fromOVERLOOKED_TESTSaccordingly.closes: #72268
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines