Share subprocess request dispatch without changing message support - #73290
Open
ephraimbuddy wants to merge 1 commit into
Open
ephraimbuddy wants to merge 1 commit into
ephraimbuddy wants to merge 1 commit into
Conversation
Task and Dag subprocesses duplicate dispatch plumbing, making their supported message boundaries and shared behavior harder to keep aligned. Keep those boundaries explicit and protect the existing wire behavior as handlers evolve.
ephraimbuddy
marked this pull request as ready for review
September 17, 2026 17:30
ephraimbuddy
requested review from
amoghrajesh,
ashb,
jedcunningham and
kaxil
as code owners
September 17, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task supervision and Dag processing duplicate their message dispatch logic. Move dispatch to
WatchedSubprocess, with an explicit supported message set for each subprocess and common requests delegated torequest_handlers.py.Preserve existing wire responses, error categories, serialization options, and process-specific behavior. Typed registration checks message/handler compatibility, method lookup honors overrides, and an explicit sentinel marks responses already sent.
Add parity tests for the exact supported message sets and shared handler reuse, alongside dispatch regression tests and negative typing cases.
This is a narrower alternative to #68106, with the same goal of sharing dispatch.
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6) following the guidelines