feat(go/adbc/driver/flightsql): promote safe call headers into FlightSQL spans#4570
Open
binarycat-dremio wants to merge 1 commit into
Open
Conversation
binarycat-dremio
marked this pull request as ready for review
July 22, 2026 11:02
Contributor
Author
|
cc: @lidavidm you could be interested |
binarycat-dremio
force-pushed
the
feat/call-header-tracing-span-attrs
branch
from
July 23, 2026 10:36
e3f028d to
03bf5b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes allowlisted
adbc.flight.sql.rpc.call_header.*metadata into FlightSQL OpenTelemetry span attributes.This adds tracing support for safe correlation headers on:
FlightSQLDatabase.OpenFlightSQLStatement.PrepareFlightSQLStatement.ExecuteQueryFlightSQLStatement.ExecuteUpdateHeaders are exposed as attributes like
rpc.call_header.x-request-id.Usage examples
Safe
rpc.call_header.*values may be configured at connection level:or at statement/cursor level:
Why
FlightSQL already sends caller-supplied
rpc.call_header.*values on outbound RPCs, but those values were not visible in tracing spans. Surfacing allowlisted correlation headers makes it easier to connect ADBC client spans with upstream request IDs and external traces.Related
Closes #4568.