ci: pass env vars down into cibuildwheel container#4585
Open
amoeba wants to merge 1 commit into
Open
Conversation
amoeba
marked this pull request as draft
July 24, 2026 18:48
Member
Author
|
Converted to draft until I can verify this fixes the issue. |
amoeba
marked this pull request as ready for review
July 24, 2026 19:35
Member
Author
|
This looks good to me. I compared the wheel filenames between a run with and without this change. CI run before: https://github.com/apache/arrow-adbc/actions/runs/30089666671/job/89469920732 In each CI run, I downloaded the artifacts from the "Archive wheels" step and compared them to show this PR fixes the filename inconsistency: # without this change
$ ls -1 python-amd64-manylinux-before/adbc_driver_manager/repaired_wheels/
adbc_driver_manager-1.12.0.dev0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0.dev0-cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
# with this change, wheels no longer have `.dev0`
$ ls -1 python-amd64-manylinux-after/adbc_driver_manager/repaired_wheels/
adbc_driver_manager-1.12.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl
adbc_driver_manager-1.12.0-cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the filenames of our driver manager wheel nightlies consistent. While nightlies are not official project artifacts and users should never depend on them, it's nice to make them a bit easier to use.
As noticed in #4578, the manylinux wheels for the driver manager use a
.dev0prefix whereas all other wheels just use the MAJOR.MINOR.PATCH. The driver manager manylinux wheels are special in that they go through cibuildwheel and cibuildwheel uses an inner container for its build. To get a consistent version, we need let cibuildwheel passSETUPTOOLS_SCM_PRETEND_VERSIONinto the container.