fix: remove superfluous struct field index compare#970
Open
Willem-J-an wants to merge 1 commit into
Open
Conversation
The check is superfluous because: - Length is verified to equal - Next step iterates over fields & asserts the names are equal for each index. These 2 steps essentially check the same thing, without needing expensive DeepEqual of 2 maps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Remove superfluous check in the TypeEqual path to improve performance
Rationale for this change
The check is superfluous because:
Are these changes tested?
passes on
go test -v ./arrowAre there any user-facing changes?
No