docs(parquet): Add thrift generation contribution info#971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When making changes to parquet-related logic sometimes contributors need to regenerate thrift generated files. I did this for #960 However since the thrift definitions don't live in this repo, it might be worth documenting for new users.
These docs are based on my understanding from discussions with maintainers in the iceberg go slack.
Feel free to close or propose / make direct edits as you see fit
What changes are included in this PR?
Just documentation
Are these changes tested?
No since they are just docs
Are there any user-facing changes?
No