feat(arrow/array): Add Builder.Truncate() method#981
Closed
serramatutu wants to merge 9 commits into
Closed
Conversation
Builder.Truncate() methodBuilder.Truncate() method
Contributor
Author
|
After talking with Matt I decided to close this and do something else for that PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can review commit by commit.
Rationale for this change
While working on this change, I ran into an issue: when a struct builder runs into an error while decoding one of the columns from JSON, there is no way to "un-append" rows from its sibling rows.
The two options are to either (1)
AppendNull()to all siblings and return the error, which would leave a bad row behind, or (2) eagerlyreturn errand leave the builder in a broken state.What I want to do instead is:
What changes are included in this PR?
Add
Truncate(n int)to theBuilderinterface. This new method will keep the underlying buffers but truncate the arrays to at most lengthn. It keepsLen()andNullN()sound. Callingb.Truncate(b.Len() - 1)is the equivalent of "un-appending" one element.Are these changes tested?
Yes, I added a
TestBuilderTruncatethat checks thatTruncateworks for all data types.It's worth noting I wanted to call
ValidateFull()after truncate, but it seems like REE arrays have an issue withValidateFull()that precedes this PR.Are there any user-facing changes?
Yes, this adds a new method to the public API of
Builder