Repository navigation
DX-105241: Support Flight SQL batch updates - #1410
Draft
mykolapavlov-dremio wants to merge 1 commit into
Draft
mykolapavlov-dremio wants to merge 1 commit into
mykolapavlov-dremio wants to merge 1 commit into
Conversation
Collect all prepared-statement update results and translate partial batch failures to BatchUpdateException. Close response buffers on success and failure to prevent allocator leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Arrow Flight SQL JDBC prepared-statement batch handling for servers that emit one update result per parameter row.
The client now collects all update counts, exposes one count per batch entry, translates partial failures to
BatchUpdateException, and releases response buffers on success and failure.Changes
executeUpdateBatch()to the Flight SQL prepared-statement client.PutResult.SyncPutListenersafe against late callbacks during cleanup.BatchUpdateException.Test plan
BatchUpdateExceptionwith partial counts.Related