feat: add deregister to ObjectStoreRegistry#784
Open
kszucs wants to merge 1 commit into
Open
Conversation
Add `ObjectStoreRegistry::deregister`, the inverse of `register`: it removes the store registered at the exact scheme/authority/path of a URL and returns it, pruning emptied tree branches. A default implementation returns `None`, so the addition is non-breaking for existing implementors.
kszucs
force-pushed
the
registry-deregister
branch
from
4cb3324 to
adaee28
Compare
kylebarron
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No tracking issue; happy to file one if preferred.
Rationale for this change
ObjectStoreRegistrycanregisterandresolvestores but has no way to remove one. Consumers that register stores dynamically (e.g. per-session) need to deregister them as well.What changes are included in this PR?
ObjectStoreRegistry::deregister(&self, url: &Url) -> Option<Arc<dyn ObjectStore>>, the inverse ofregister, with a default implementation returningNone.DefaultObjectStoreRegistry: removes the store at the exact scheme/authority/path ofurl(siblings and longer prefixes are left in place) and prunes emptied tree branches.Are there any user-facing changes?
Yes: a new
ObjectStoreRegistry::deregistertrait method. It has a default implementation, so existing implementors are unaffected.