Skip to content

GH-33420: [R] Improve error message when providing a mix of readr and Arrow options#50048

Open
Rich-T-kid wants to merge 2 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/better-error-handling
Open

GH-33420: [R] Improve error message when providing a mix of readr and Arrow options#50048
Rich-T-kid wants to merge 2 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/better-error-handling

Conversation

@Rich-T-kid
Copy link
Copy Markdown

@Rich-T-kid Rich-T-kid commented May 27, 2026

Rationale for this change

closes #33420

What changes are included in this PR?

updates the error message returned

Are these changes tested?

No, minimal change so I don't think its needed

Are there any user-facing changes?

better error responses for users.

Copilot AI review requested due to automatic review settings May 27, 2026 04:58
@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@Rich-T-kid
Copy link
Copy Markdown
Author

@thisisnic could you take a look at this? 🫡 thx

@thisisnic
Copy link
Copy Markdown
Member

Thanks for the PR @Rich-T-kid! Looks pretty good, just a couple of suggested changes from me:

  • please could you update the PR title to include the issue number/name (see other PRs in the repo for examples)
  • please could you either add or update any tests for these errors

Give me a shout if you have any question!

@Rich-T-kid Rich-T-kid changed the title resolves #33420 GH-33420[R] Provide better error message to user May 27, 2026
@thisisnic thisisnic changed the title GH-33420[R] Provide better error message to user GH-33420: [R] Provide better error message to user May 27, 2026
@thisisnic thisisnic changed the title GH-33420: [R] Provide better error message to user GH-33420: [R] Improve error message when providing a mix of readr and Arrow options May 27, 2026
@Rich-T-kid
Copy link
Copy Markdown
Author

Rich-T-kid commented May 27, 2026

@thisisnic / @Jonahkel pushed a PR that updates a test. Could you take another look 😄

@Jonahkel
Copy link
Copy Markdown
Contributor

@thisisnic / @Jonahkel pushed a PR that updates a test. Could you take another look 😄

Hi! Looks good to me!
...just kidding. I assume you meant to ping @jonkeane ? ;)

@Rich-T-kid
Copy link
Copy Markdown
Author

@thisisnic just wanted to bump this

@thisisnic
Copy link
Copy Markdown
Member

thisisnic commented May 29, 2026

@thisisnic just wanted to bump this

Please don't ping maintainers repeatedly. There are some guidelines on project etiquette here: https://community.apache.org/contributors/etiquette.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R] Improve error message when providing a mix of readr and Arrow options

3 participants