GH-50052: [CI][C++] Bump vcpkg to newest version#50053
Open
raulcd wants to merge 2 commits into
Open
Conversation
|
|
Member
Author
|
@github-actions crossbow submit wheelcp314 |
|
Revision: a0e4312 Submitted crossbow builds: ursacomputing/crossbow @ actions-de3763ceb9
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Arrow’s CI/container toolchain to use a newer vcpkg commit, along with supporting tweaks needed for dependency builds (notably in the manylinux wheel image).
Changes:
- Bump the default vcpkg commit used by CI/docker builds and refresh the vcpkg ports patch accordingly.
- Add a CI helper script to build/install a newer bison, and install it in the manylinux Python wheel image to satisfy thrift build requirements.
- Update Windows wheel image revision tags to force rebuilds with the new vcpkg/tooling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ci/vcpkg/ports.patch |
Updates vcpkg port overlays/patches for the bumped vcpkg baseline. |
ci/scripts/install_bison.sh |
Adds a script to build and install a pinned bison version from source. |
ci/docker/python-wheel-manylinux.dockerfile |
Installs newer bison in the manylinux wheel build image before running vcpkg. |
.env |
Updates the pinned vcpkg commit and Windows wheel image revision tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
awaiting changes
github-actions
Bot
added
awaiting change review
raulcd
added
awaiting changes
Member
Author
|
@github-actions crossbow submit wheelcp313 |
|
Revision: 01d11b7 Submitted crossbow builds: ursacomputing/crossbow @ actions-3800d85dfe
|
Member
Author
|
@kou @AntoinePrv this is ready. CI is green for wheels and JNI manylinux jobs. |
Comment on lines
+20
to
+34
| set -e | ||
|
|
||
| if [ "$#" -ne 2 ]; then | ||
| echo "Usage: $0 <version> <prefix>" | ||
| exit 1 | ||
| fi | ||
|
|
||
| version=$1 | ||
| prefix=$2 | ||
|
|
||
| mkdir -p /tmp/bison | ||
| url="https://ftp.gnu.org/gnu/bison/bison-${version}.tar.gz" | ||
|
|
||
| wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison --strip-components=1 | ||
|
|
Comment on lines
+30
to
+41
| mkdir -p /tmp/bison | ||
| url="https://ftp.gnu.org/gnu/bison/bison-${version}.tar.gz" | ||
|
|
||
| wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison --strip-components=1 | ||
|
|
||
| pushd /tmp/bison | ||
| ./configure --prefix="${prefix}" | ||
| make -j$(nproc) | ||
| make install | ||
| popd | ||
|
|
||
| rm -rf /tmp/bison |
kou
approved these changes
May 28, 2026
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
BTW, I thought that we may be able to install Bison by vcpkg but it's not available yet: microsoft/vcpkg#33084
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We require newer vcpkg for other PRs like upgrading xsimd, see:
What changes are included in this PR?
Are these changes tested?
Yes via CI
Are there any user-facing changes?
No