Repository navigation
Conversation
lyne7-sc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2588
Rationale for this change
When exactly one child expression needs fallback, Auron also wraps literal parameters in unevaluable
NativeExprWrapperobjects. Parent expressions that read these constants during conversion can fail to convert, causing unnecessary fallback. In TPC-DS Q2, this makes the entire projection fall back to Spark.What changes are included in this PR?
Preserve literal parameters when wrapping child expressions.
Are there any user-facing changes?
Affected projections can remain native while unsupported child expressions still use JVM fallback. Query results and public APIs are unchanged.
How was this patch tested?
AuronExpressionSuite, verifying correct results and native projection.Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: OpenAI Codex (GPT-6)ASF guidance: https://www.apache.org/legal/generative-tooling.html