Skip to content

[Python] Create temporary dataset with a 24 hour ttl. #39615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 2 commits into from
Aug 11, 2026
Merged

[Python] Create temporary dataset with a 24 hour ttl. #39615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d2e16
Create temporary dataset with a 24 hour ttl.
aebrahim May 27, 2026
a913cc2
Update sdks/python/apache_beam/io/gcp/bigquery_tools.py
aebrahim Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sdks/python/apache_beam/io/gcp/bigquery_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@
"GEOGRAPHY": str,
}

# Duplicated logic with io/gcp/bigquery_change_history.py
# Default table expiration for auto-created temp datasets: 24 hours in ms.
# Tables created in the dataset auto-expire after this duration if not
# explicitly deleted, acting as a safety net for orphaned temp tables
# (e.g. pipeline crash before cleanup runs).
_DEFAULT_TABLE_EXPIRATION_MS = 24 * 60 * 60 * 1000

@Abacn Abacn Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a genuine data loss concern if there is a long running job that some temp tables are materialized, and expired before all of them finalized to destination table?

@Abacn Abacn Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @ahmedabu98 @jrmccluskey

@ahmedabu98 ahmedabu98 Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't encountered a load/export job that takes longer than a day. But I guess it's possible. A 7-day expiration window would be safer


Comment thread
aebrahim marked this conversation as resolved.

class FileFormat(object):
CSV = 'CSV'
Expand Down Expand Up @@ -952,6 +959,7 @@ def create_temporary_dataset(
project_id,
self.temp_dataset_id,
location=location,
default_table_expiration_ms=_DEFAULT_TABLE_EXPIRATION_MS,
labels=labels,
kms_key=kms_key)

Expand Down
Loading