Fix PubSub subscription path double-prefix in stale_cleaner (#39772) - #39778
Open
waterWang wants to merge 1 commit into
Open
Fix PubSub subscription path double-prefix in stale_cleaner (#39772)#39778waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…9772) PubSubSubscriptionCleaner._delete_resource() receives resource names from list_subscriptions() which are already fully-qualified paths (e.g. "projects/<project>/subscriptions/<sub-id>"). Calling subscription_path() on them double-prefixes the path, producing "projects/<project>/subscriptions/projects/<project>/subscriptions/<sub-id>" which GCP rejects with InvalidArgument 400. The PubSubTopicCleaner._delete_resource() already handles this correctly by passing the full path directly to delete_topic(). Signed-off-by: waterWang <waterwang@apache.org>
Contributor
|
Assigning reviewers: R: @kennknowles added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Clean Up GCP Resources workflow (
beam_CleanUpGCPResources.yml) failsover 80% of the time. Root cause:
PubSubSubscriptionCleaner._delete_resource()callssubscription_path(project_id, resource_name)on a resource name that isalready a fully-qualified path from
list_subscriptions(). This producesprojects/<project>/subscriptions/projects/<project>/subscriptions/<sub-id>which GCP rejects with
InvalidArgument: 400 Invalid resource name given.PubSubTopicCleaner._delete_resource()correctly passes the full pathdirectly to
delete_topic(). This fix mirrors that pattern.Fixes #39772