fix: preserve duplicate same-timestamp elements in FlinkOrderedListState - #39783
Open
waterWang wants to merge 1 commit into
Open
fix: preserve duplicate same-timestamp elements in FlinkOrderedListState#39783waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
`readAsMap()` used `SortedMap.put()` keyed by timestamp, which silently overwrites elements sharing the same timestamp. Changed to a multimap structure (`SortedMap<Instant, List<TimestampedValue<T>>>`) using `computeIfAbsent` to accumulate all values per timestamp bucket. Fixes apache#39782 Signed-off-by: waterWang <waterwang@hermes.agent>
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #39782
Problem:
FlinkOrderedListState.readAsMap()builds aSortedMap<Instant, TimestampedValue<T>>usingMap.put()keyed by timestamp. When multiple elements share the same timestamp, the second element overwrites the first — causing silent data loss when reading the state.Fix: Changed to a multimap structure (
SortedMap<Instant, List<TimestampedValue<T>>>). UsesMap.computeIfAbsent()to accumulate all values per timestamp bucket, preserving every element. Updatedread(),readRange(), andclearRange()to flatten the multimap values.Root cause (code):
Testing:
FlinkStateInternalsTest— existing ordered-list tests cover ordering semantics; they pass unchanged since the multimap flattens back to the same sorted order. The scoped PR change is behavior-preserving for unique timestamps and fixes duplicate-timestamp data loss.Docs / changelog: This is a bug fix; no user-facing API change.