Fix FlinkOrderedListState: preserve elements with same timestamp - #39795
Open
waterWang wants to merge 1 commit into
Open
Fix FlinkOrderedListState: preserve elements with same timestamp#39795waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
FlinkOrderedListStatedata loss when multiple elements with the same timestamp are added to anOrderedListState.Root cause: The
readAsMap()method builds aTreeMap<Instant, TimestampedValue<T>>keyed by the element's timestamp. When a timestamp is shared by multiple elements,Map.put()silently overwrites the previous entry, destroying data.Fix: Change the internal structure to
SortedMap<Instant, List<TimestampedValue<T>>>, usingcomputeIfAbsentto append same-timestamp elements to a list instead of overwriting. All callers (read(),readRange(),clearRange()) are updated to flatten the list viaIterables.concat().Fixes #39782