Skip to content

Fix broken GlobalWindow singleton #40910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abacn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix broken GlobalWindow singleton #40910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sdks/python/apache_beam/transforms/window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,14 @@ class GlobalWindow(BoundedWindow):
def __new__(cls):
if cls._instance is None:
cls._instance = super(GlobalWindow, cls).__new__(cls)
super(GlobalWindow,
cls._instance).__init__(GlobalWindow._getTimestampFromProto())
return cls._instance

def __init__(self) -> None:
super().__init__(GlobalWindow._getTimestampFromProto())
# Intentionally a no-op: super().__init__ is called once in __new__
# so repeated GlobalWindow() calls do not re-initialize the singleton.
pass

def __repr__(self):
return 'GlobalWindow'
Expand Down
Loading