Skip to content

Cherrypick #40923 Fix collections.abc pretty type - #40924

Merged
Amar3tto merged 1 commit into
release-2.78from
cp-40923
Oct 31, 2026
Merged

Amar3tto merged 1 commit into
release-2.78from
cp-40923

Conversation

@Amar3tto

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added python size/xs XS: <10 lines changed labels Oct 31, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR cleanly cherry-picks #40923 onto the release-2.78 branch to handle collections.abc module types in pretty_type within sdks/python/gen_xlang_wrappers.py. The change is minimal, accurate, and ready to merge.

🔍 General Feedback

  • Clean cherry-pick with no conflicts or unintended modifications.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
Backup reviewer: jrmccluskey (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
github-actions Bot requested a review from damccorm October 31, 2026 12:12
@Amar3tto
Amar3tto merged commit 7cce048 into release-2.78 Oct 31, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants