[MQTT] Stop QoS0 push from refreshing keepalive#263
Merged
Conversation
popduke
force-pushed
the
codex/qos0-keepalive-idle
branch
from
f3a682c to
747f495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260
QoS0 outbound PUBLISH refreshes MQTT keepalive idle timer and delays LWT for half-open clients
Summary
Stop outbound QoS0 PUBLISH write success from refreshing the MQTT session keepalive activity timestamp.
Motivation
When a client becomes half-open or loses power, the broker may still keep sending QoS0 downstream PUBLISH packets to that connection. Previously, successful QoS0 downstream writes updated
lastActiveAtNanos, which could postpone keepalive idle detection and delay LWT publication even though the client no longer sends MQTT packets.Changes
lastActiveAtNanos = sessionCtx.nanoTime()from the QoS0 downstream write-success path.Tests