[CALCITE-6654] NUMERIC/DECIMAL columns without explicit precision should not throw \"DECIMAL precision 0 must be between 1 and 19 by mmoradi0101 · Pull Request #4872 · apache/calcite

mmoradi0101 · 2026-04-08T12:41:05Z

Jira Link

Changes Proposed

JdbcSchema.sqlType() threw an IllegalArgumentException when a column
was declared without explicit precision. Oracle reports precision=0 and
scale=-127 for such columns (e.g. NUMBER), PostgreSQL and MSSQL report
precision=0 and scale=0 (e.g. NUMERIC, DECIMAL).

Treat precision=0 (and Oracle's scale=-127) as "no precision
specified" and fall back to the plain SQL type instead of throwing.

Testing

Added JdbcSchemaDecimalBugTest with 4 integration tests covering Oracle,
PostgreSQL, MSSQL, and a regression test for explicit DECIMAL(10,2).

mihaibudiu · 2026-04-11T00:58:56Z

    }
  }

+  private static boolean isAffectedTypeForMissingPrecision(SqlTypeName sqlTypeName) {


This function looks like overkill.
Do you expect it will need to cover other cases too?
I would just inline the function.

the condition is now just sqlTypeName == SqlTypeName.DECIMAL directly at the call site.

mihaibudiu · 2026-04-11T00:59:27Z

    } else if (precision >= 0 && sqlTypeName.allowsPrecNoScale()) {
+
+      // Fix for CALCITE-6654:
+      // Oracle returns scale=-127 for NUMBER without precision


The comment about oracle is informative, but it's not clear how it relates to the code here.

mihaibudiu · 2026-04-11T01:17:06Z

+ */
+@Tag("integration")
+@EnabledIfSystemProperty(named = "calcite.integration.tests", matches = "true")
+public class JdbcSchemaDecimalBugTest {


I don't understand where the DECIMAL without precision is.
Where is this table test_numbers?

I've updated the tests to create the table within each test method using CREATE TABLE ... (val NUMERIC) / (val DECIMAL) / (val NUMBER) without explicit precision, which is exactly the scenario that triggers CALCITE-6654. The table is dropped and recreated at the start of each test run.

mihaibudiu · 2026-04-14T20:17:33Z

I see this is a draft, please request a new review when this is ready

mihaibudiu · 2026-04-17T21:11:48Z

Is this ready for review?

mmoradi0101 · 2026-04-21T12:20:15Z

Is this ready for review?
Yes, this is ready for review. Thank you for your patience. @mihaibudiu

sonarqubecloud · 2026-04-21T12:47:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mihaibudiu · 2026-04-29T04:18:24Z

+ * Run with:
+ ** {@code ./gradlew :core:integTestCalcite6654}
+ *
+ * <p>Required Docker containers (see docker-compose in src/test/resources):


I could not find a file named docker-compose in this repository.
What does this refer to?

I've added the docker-compose.yml to core/src/test/resources/ and updated the Javadoc reference accordingly. @mihaibudiu

…thout explicit precision [CALCITE-6654] Handle NUMERIC/DECIMAL columns without explicit precision in JdbcSchema [CALCITE-6654] Fix JdbcSchema error for DECIMAL/NUMERIC columns without explicit precision

…cite-6654-decimal-precision

mihaibudiu · 2026-05-11T20:18:41Z

you should use new commits for changes until they are approved, and squash at that point

mmoradi0101 · 2026-05-12T06:29:37Z

you should use new commits for changes until they are approved, and squash at that point
Understood, I didn't realize the rebase was squashing my commits. From now on I'll only add new commits and squash after approval. Thanks for the clarification! The failing test testExtractValue() appears to be unrelated to this PR.. it fails with an XML well formedness error, not related to DECIMAL precision handling. Could this be a pre-existing flaky test?
@mihaibudiu

mihaibudiu · 2026-05-12T18:49:38Z

you can check the changes using ./gradlew build, please fix the issues reported by CI and re-request a review

thomaskirz

Fix linter-reported formatting issues. This should resolve the CI error.

thomaskirz · 2026-05-20T14:09:02Z

+  /**
+   * PostgreSQL {@code NUMERIC} without precision (e.g. {@code col NUMERIC})
+   * must not cause Calcite to throw.
+   * <p>PostgreSQL reports {@code precision=0, scale=0} for such columns.


Suggested change

* <p>PostgreSQL reports {@code precision=0, scale=0} for such columns.

*

* <p>PostgreSQL reports {@code precision=0, scale=0} for such columns.

thomaskirz · 2026-05-20T14:09:33Z

+           ResultSet rs =
+               st.executeQuery("SELECT * FROM \"oracle\".\"TEST_NUMBERS\"")) {
+        while (rs.next()) {
+          //drain


Suggested change

//drain

// drain

mmoradi0101 · 2026-05-21T07:53:31Z

Fixed the two checkstyle issues, CI should pass now.

thomaskirz · 2026-05-21T08:04:04Z

thanks. seems like there are still some issues, i'll have a look at it

thomaskirz · 2026-05-21T08:36:19Z

https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/PR-4872/7/cloudbees-pipeline-explorer/?line=511

looks like a test assertion is failing

sonarqubecloud · 2026-05-21T08:51:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mmoradi0101 · 2026-05-21T11:31:48Z

Thanks for the review, @thomaskirz and @mihaibudiu! I see that PR #4941 was merged to main with a similar fix, so I'm closing this PR as superseded. I also verified that #4941 covers the Oracle case (precision=0, scale=-127) via the fallthrough path.

mihaibudiu reviewed Apr 11, 2026

View reviewed changes

mmoradi0101 marked this pull request as draft April 13, 2026 14:31

mmoradi0101 marked this pull request as ready for review April 15, 2026 07:13

mmoradi0101 closed this Apr 21, 2026

mmoradi0101 reopened this Apr 21, 2026

mihaibudiu reviewed Apr 29, 2026

View reviewed changes

thomaskirz mentioned this pull request May 9, 2026

Update dependency org.apache.calcite:calcite-core to v1.41.0 eisop/oopsie#100

Open

1 task

[CALCITE-6654] JdbcSchema throws error for NUMERIC/DECIMAL columns wi…

e381117

…thout explicit precision [CALCITE-6654] Handle NUMERIC/DECIMAL columns without explicit precision in JdbcSchema [CALCITE-6654] Fix JdbcSchema error for DECIMAL/NUMERIC columns without explicit precision

mmoradi0101 force-pushed the fix/calcite-6654-decimal-precision branch from 731edd5 to e381117 Compare May 11, 2026 08:46

Merge branch 'main' of https://github.com/apache/calcite into fix/cal…

9dbe143

…cite-6654-decimal-precision

thomaskirz suggested changes May 20, 2026

View reviewed changes

mmoradi0101 requested a review from mihaibudiu May 21, 2026 07:52

[CALCITE-6654] Checkstyle formatting in JdbcSchemaDecimalBugTest

ae9d27b

mmoradi0101 force-pushed the fix/calcite-6654-decimal-precision branch from 87fd4a0 to ae9d27b Compare May 21, 2026 08:37

Merge branch 'apache:main' into fix/calcite-6654-decimal-precision

63f4ffa

mmoradi0101 closed this May 22, 2026

	* <p>PostgreSQL reports {@code precision=0, scale=0} for such columns.
	*
	* <p>PostgreSQL reports {@code precision=0, scale=0} for such columns.

Conversation

mmoradi0101 commented Apr 8, 2026

Jira Link

Changes Proposed

Testing

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mihaibudiu commented Apr 14, 2026

Uh oh!

mihaibudiu commented Apr 17, 2026

Uh oh!

mmoradi0101 commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 21, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mihaibudiu commented May 11, 2026

Uh oh!

mmoradi0101 commented May 12, 2026

Uh oh!

mihaibudiu commented May 12, 2026

Uh oh!

thomaskirz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmoradi0101 commented May 21, 2026

Uh oh!

thomaskirz commented May 21, 2026

Uh oh!

thomaskirz commented May 21, 2026

Uh oh!

sonarqubecloud Bot commented May 21, 2026

Quality Gate passed

Uh oh!

mmoradi0101 commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mmoradi0101 commented Apr 21, 2026 •

edited

Loading

mmoradi0101 commented May 21, 2026 •

edited

Loading