Skip to content

[CALCITE-7242] Implement a rule to eliminate LITERAL_AGG so that other databases can handle it#5058

Open
xiedeyantu wants to merge 1 commit into
apache:mainfrom
xiedeyantu:CALCITE-7242
Open

[CALCITE-7242] Implement a rule to eliminate LITERAL_AGG so that other databases can handle it#5058
xiedeyantu wants to merge 1 commit into
apache:mainfrom
xiedeyantu:CALCITE-7242

Conversation

@xiedeyantu

Copy link
Copy Markdown
Member

Jira Link

CALCITE-7242

@xiedeyantu xiedeyantu marked this pull request as draft June 30, 2026 04:01
@xiedeyantu

Copy link
Copy Markdown
Member Author

Modifications were made based on #4598, and some new tests were added.

@xiedeyantu

Copy link
Copy Markdown
Member Author

@iwanttobepowerful I’ve added you as a collaborator. Please take a look at this PR when you have a chance, or feel free to submit a new one if you prefer.

@xiedeyantu xiedeyantu marked this pull request as ready for review June 30, 2026 14:25
Comment thread core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java Outdated
Comment thread core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml Outdated
Comment thread core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml Outdated
@xiedeyantu

Copy link
Copy Markdown
Member Author

@iwanttobepowerful Could you please take another look when you have a moment? Also, would it be okay to squash the commits?

@xiedeyantu xiedeyantu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jul 1, 2026
…r databases can handle it

Co-authored-by: Weihua Zhang <745778074@qq.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@xiedeyantu

Copy link
Copy Markdown
Member Author

If there are no further comments, I will merge this in 48 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants