[CALCITE-7740] Harden ModelHandler against content-dependent errors - #5221
Open
rubenada wants to merge 2 commits into
Open
[CALCITE-7740] Harden ModelHandler against content-dependent errors#5221rubenada wants to merge 2 commits into
rubenada wants to merge 2 commits into
Conversation
xuzifu666
approved these changes
Aug 26, 2026
xuzifu666
left a comment
xuzifu666
left a comment
Member
There was a problem hiding this comment.
LGTM, only two comments regarding exception handling were left.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7740
Changes Proposed
Harden ModelHandler against content-dependent errors: sanitize parse-error text for non-inline models, add optional calcite.model.baseDirectory system property, add some clarifications in this regard to the threat model.