Skip to content

CASSANDRA-21692 Accord LWT can discard condition in IF statement + Journal error handling incorrectly calculates bufferPosition - #5180

Open
alanwang67 wants to merge 2 commits into
apache:trunkfrom
alanwang67:accordLWT
Open

alanwang67 wants to merge 2 commits into
apache:trunkfrom
alanwang67:accordLWT

Conversation

@alanwang67

Copy link
Copy Markdown
Contributor
  1. When we have a condition on a static row and a condition on a regular row we can discard the condition on the regular row for Accord LWTs
  2. L148 and L158 in
    return handleReadException(e, from.position() + headerSize, syncedOffset);
    , should be start + headerSize instead of from.position() + headerSize and start + totalSize instead of from.position() respectively since crc.update(from) in readAndUpdateHeaderCrc changes the buffer's position

reviewed by for CASSANDRA-21692

Co-authored-by: Name1
Co-authored-by: Name2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants