Conversation
patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21645
frankgh
reviewed
Sep 19, 2026
| protected final EventLoop eventLoop; | ||
| private final ConcurrentLinkedQueue<FlushItem<?>> queued = new ConcurrentLinkedQueue<>(); | ||
| // Many request threads produce, but only the event loop this flusher belongs to consumes, so an MPSC queue is enough. | ||
| private final MpscUnboundedArrayQueue<FlushItem<?>> queued = new MpscUnboundedArrayQueue<>(256); |
Contributor
There was a problem hiding this comment.
poll can spin now potentially, and it will do so in the event loop. We could relax the poll by calling queued.relaxedPoll() instead in the org.apache.cassandra.transport.Flusher#poll method to be on the safe side.
Contributor
There was a problem hiding this comment.
Also, maybe we can ground the initialization value here based on something .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21645