Skip to content

Update docs#211

Merged
yadvr merged 5 commits into
apache:4.15from
shapeblue:update-docs
Jun 7, 2021
Merged

Update docs#211
yadvr merged 5 commits into
apache:4.15from
shapeblue:update-docs

Conversation

@davidjumani

@davidjumani davidjumani commented Apr 27, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@yadvr

yadvr commented Apr 27, 2021

Copy link
Copy Markdown
Member

@davidjumani conflict on master branch, or is it for 4.15 branch?

@davidjumani davidjumani changed the base branch from master to 4.15 April 27, 2021 10:29
@davidjumani davidjumani marked this pull request as ready for review April 27, 2021 10:29
@davidjumani

davidjumani commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

@rhtyd It's for 4.15, to be merged after #207 is merged

@davidjumani

davidjumani commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

@blueorangutan docbuild

@blueorangutan

blueorangutan commented Apr 27, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 27, 2021

Copy link
Copy Markdown

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/211. (SL-JID 48)

@yadvr

yadvr commented May 24, 2021

Copy link
Copy Markdown
Member

@davidjumani pl address merge conflicts

@davidjumani

davidjumani commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

@rhtyd Conflicts resolved

@yadvr yadvr added this to the 4.15 milestone May 25, 2021
@yadvr

yadvr commented May 25, 2021

Copy link
Copy Markdown
Member

@blueorangutan docbuild

@blueorangutan

blueorangutan commented May 25, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 25, 2021

Copy link
Copy Markdown

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/211. (SL-JID 76)

@yadvr yadvr requested a review from andrijapanicsb June 4, 2021 09:35
@yadvr

yadvr commented Jun 4, 2021

Copy link
Copy Markdown
Member

@andrijapanicsb are you lgtm on this cc @DaanHoogland

@andrijapanicsb

andrijapanicsb commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

LGTM in regards to the new images.

I have not reviewed tons of other space and indentation changes

@DaanHoogland

DaanHoogland commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

ok, let's merge, we can always amend as we go (it's only confusing docs anyways) , @rhtyd ?

@yadvr yadvr merged commit 26e4a11 into apache:4.15 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrijapanicsb andrijapanicsb andrijapanicsb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15

Development

Successfully merging this pull request may close these issues.

5 participants

@davidjumani @yadvr @blueorangutan @andrijapanicsb @DaanHoogland