Skip to content

fixed label for aclname#12196

Closed
kiranchavala wants to merge 1 commit into
apache:mainfrom
kiranchavala:ui-fix-labelacl
Closed

fixed label for aclname#12196
kiranchavala wants to merge 1 commit into
apache:mainfrom
kiranchavala:ui-fix-labelacl

Conversation

@kiranchavala

Copy link
Copy Markdown
Member

This pr fix the label issue

Create a vpc tier and associate a acl rule to it and check the network details

Before the fix

beforeacl

After fix

afteracl

@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (2600965) to head (3b88e2d).
⚠️ Report is 153 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12196      +/-   ##
============================================
- Coverage     17.57%   17.56%   -0.01%     
+ Complexity    15550    15546       -4     
============================================
  Files          5913     5913              
  Lines        529427   529427              
  Branches      64677    64677              
============================================
- Hits          93024    93001      -23     
- Misses       425940   425965      +25     
+ Partials      10463    10461       -2     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kiranchavala

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12196 (QA-JID-818)

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti

sureshanaparti commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@kiranchavala can you check if this can be targeted to 4.20?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix a label issue where ACL name values were displayed with an incorrect label. The change adds a new translation key label.aclname to the English locale file.

  • Added label.aclname translation key to ui/public/locales/en.json

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui/public/locales/en.json
"label.accounttype": "Account type",
"label.acl.export": "Export ACL rules",
"label.acl.id": "ACL ID",
"label.aclname": "ACL Name",

Copilot AI Dec 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation key label.aclname is added only to en.json, but it should also be added to other locale files for consistency. Other major locale files like zh_CN.json, ja_JP.json, de_DE.json, fr_FR.json, etc., are missing this translation.

Additionally, the existing code in InfoCard.vue (line 586) and VpcTiersTab.vue (line 53) still uses $t('label.aclid') as the label while displaying the aclname value. These should be updated to use $t('label.aclname') to properly fix the label mismatch issue shown in the PR description.

Copilot uses AI. Check for mistakes.
@kiranchavala

Copy link
Copy Markdown
Member Author

@kiranchavala can you check if this can be targeted to 4.20?

@sureshanaparti the issue is not present in 4.20.1

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor comment

Comment thread ui/public/locales/en.json
"label.accounttype": "Account type",
"label.acl.export": "Export ACL rules",
"label.acl.id": "ACL ID",
"label.aclname": "ACL Name",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be moved after label.aclid to maintain the order

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or better change label name to label.acl.name in both files

@bernardodemarco bernardodemarco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

closing in favour of #12511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants