Remove unused config consoleproxy.cmd.port by sureshanaparti · Pull Request #12807 · apache/cloudstack

sureshanaparti · 2026-03-13T04:39:55Z

Description

This PR removes unused config 'consoleproxy.cmd.port'.

The config 'consoleproxy.cmd.port' reference is removed in 4.11.1.0 here: #2562. Before 4.11.1.0, it is referenced but not used -

cloudstack/server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java

Lines 1246 to 1247 in b923c22

    
           String value = configs.get(Config.ConsoleProxyCmdPort.key()); 
        
           value = configs.get("consoleproxy.sslEnabled");

Fixes #11615

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2026-03-13T04:42:14Z

@blueorangutan package

Copilot

Pull request overview

This PR aims to remove the legacy/unused global setting consoleproxy.cmd.port as part of the 4.22.0.0 → 4.22.1.0 schema upgrade, to avoid exposing a misleading configuration option.

Changes:

Adds a DB migration step to delete consoleproxy.cmd.port from cloud.configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

codecov · 2026-03-13T05:03:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.61%. Comparing base (7c7b2ae) to head (d798e4f).
⚠️ Report is 4 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12807      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
+ Complexity    15690    15689       -1     
============================================
  Files          5918     5918              
  Lines        531914   531913       -1     
  Branches      65047    65047              
============================================
- Hits          93688    93685       -3     
- Misses       427662   427663       +1     
- Partials      10564    10565       +1

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.68% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2026-03-13T05:06:27Z

@blueorangutan package

blueorangutan · 2026-03-13T05:08:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-13T06:08:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17126

sudo87

clgtm

github-actions · 2026-03-24T19:12:05Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2026-03-25T10:30:23Z

@blueorangutan package

blueorangutan · 2026-03-25T10:32:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-03-25T11:28:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17241

DaanHoogland

clgtm, will be hard to prove completeness, but at least some manual regression testing will be needed.

github-actions · 2026-04-02T04:19:24Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2026-04-02T05:20:04Z

@blueorangutan package

blueorangutan · 2026-04-02T05:22:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-02T06:22:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17340

github-actions · 2026-04-10T23:11:06Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2026-04-11T10:04:21Z

@blueorangutan package

blueorangutan · 2026-04-11T10:06:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-11T10:56:40Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17456

sureshanaparti · 2026-04-11T11:38:32Z

@blueorangutan package

blueorangutan · 2026-04-11T11:40:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-11T12:35:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17457

DaanHoogland · 2026-04-13T06:47:55Z

@blueorangutan test

blueorangutan · 2026-04-13T06:50:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-04-13T21:31:39Z

[SF] Trillian test result (tid-15859)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50018 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12807-t15859-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py

rajujith

LGTM
Tested , consoleproxy.cmd.port is removed

Source local/main commit: - f0f0218dcb server: remove unused console proxy command port config Source Apache commits: - feb6076 Remove unused config consoleproxy.cmd.port (apache#12807) Change summary: - remove the unused ConsoleProxyCmdPort config key from ConsoleProxyManager - stop exposing consoleproxy.cmd.port through ConsoleProxyManagerImpl.getConfigKeys() - delete stale consoleproxy.cmd.port rows during the 4.22.0.0 -> 4.22.1.0 schema upgrade - record Record 034 sync notes in the history document Functional impact: - removes an unused console proxy setting from surfaced configuration lists - cleans obsolete configuration data during upgrade - does not change active console proxy runtime behavior Validation: - cherry-pick from local/main applied cleanly on ablestack-europa - mvn/mvnw-based Java tests not run in this environment by request

boring-cyborg Bot added component:api component:orchestration component:UI component:vpc labels Mar 13, 2026

sureshanaparti changed the base branch from main to 4.22 March 13, 2026 04:40

sureshanaparti added this to the 4.22.1 milestone Mar 13, 2026

sureshanaparti added this to Apache CloudStack 4.22.1 Mar 13, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Mar 13, 2026

sureshanaparti linked an issue Mar 13, 2026 that may be closed by this pull request

consoleproxy.cmd.port configuration is unused (legacy/no-op) #11615

Closed

sureshanaparti requested a review from Copilot March 13, 2026 04:42

Copilot started reviewing on behalf of sureshanaparti March 13, 2026 04:43 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

Comment thread engine/schema/src/main/resources/META-INF/db/schema-42200to42210.sql

sureshanaparti requested review from DaanHoogland and RosiKyu March 13, 2026 07:40

sudo87 approved these changes Mar 13, 2026

View reviewed changes

github-actions Bot added the status:has-conflicts label Mar 24, 2026

sureshanaparti force-pushed the remove-unused-config-consoleproxy.cmd.port branch from 8dbb5d0 to bc12ec5 Compare March 25, 2026 10:30

github-actions Bot removed the status:has-conflicts label Mar 25, 2026

DaanHoogland approved these changes Mar 29, 2026

View reviewed changes

github-actions Bot added the status:has-conflicts label Apr 2, 2026

sureshanaparti added 2 commits April 2, 2026 10:49

Remove unused config 'consoleproxy.cmd.port'

4e701b6

Remove the config key

e337f91

sureshanaparti force-pushed the remove-unused-config-consoleproxy.cmd.port branch from bc12ec5 to e337f91 Compare April 2, 2026 05:19

github-actions Bot removed the status:has-conflicts label Apr 2, 2026

GaOrtiga approved these changes Apr 9, 2026

View reviewed changes

sureshanaparti added the ready-for-testing label Apr 10, 2026

github-actions Bot added the status:has-conflicts label Apr 10, 2026

Merge branch '4.22' into remove-unused-config-consoleproxy.cmd.port

d798e4f

sureshanaparti removed the status:has-conflicts label Apr 13, 2026

rajujith approved these changes Apr 14, 2026

View reviewed changes

sureshanaparti merged commit feb6076 into apache:4.22 Apr 14, 2026
25 of 26 checks passed

github-project-automation Bot moved this from In Progress to Done in Apache CloudStack 4.22.1 Apr 14, 2026

sureshanaparti deleted the remove-unused-config-consoleproxy.cmd.port branch April 14, 2026 08:10

sureshanaparti mentioned this pull request Apr 14, 2026

consoleproxy.cmd.port configuration is unused (legacy/no-op) #11615

Closed

	String value = configs.get(Config.ConsoleProxyCmdPort.key());
	value = configs.get("consoleproxy.sslEnabled");

Conversation

sureshanaparti commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Mar 13, 2026

Uh oh!

blueorangutan commented Mar 13, 2026

Uh oh!

blueorangutan commented Mar 13, 2026

Uh oh!

sudo87 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

sureshanaparti commented Mar 25, 2026

Uh oh!

blueorangutan commented Mar 25, 2026

Uh oh!

blueorangutan commented Mar 25, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

sureshanaparti commented Apr 2, 2026

Uh oh!

blueorangutan commented Apr 2, 2026

Uh oh!

blueorangutan commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

DaanHoogland commented Apr 11, 2026

Uh oh!

blueorangutan commented Apr 11, 2026

Uh oh!

blueorangutan commented Apr 11, 2026

Uh oh!

sureshanaparti commented Apr 11, 2026

Uh oh!

blueorangutan commented Apr 11, 2026

Uh oh!

blueorangutan commented Apr 11, 2026

Uh oh!

DaanHoogland commented Apr 13, 2026

Uh oh!

blueorangutan commented Apr 13, 2026

Uh oh!

blueorangutan commented Apr 13, 2026

Uh oh!

rajujith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

sureshanaparti commented Mar 13, 2026 •

edited

Loading

codecov Bot commented Mar 13, 2026 •

edited

Loading