Batch-load VM details in CapacityManagerImpl.updateCapacityForHost to eliminate N+1 queries#13410
Open
vishesh92 wants to merge 1 commit into
Open
Batch-load VM details in CapacityManagerImpl.updateCapacityForHost to eliminate N+1 queries#13410vishesh92 wants to merge 1 commit into
vishesh92 wants to merge 1 commit into
Conversation
… eliminate N+1 queries updateCapacityForHost called listDetailsKeyPairs per VM (50-100+ round-trips per host). Now batch-loads all VM details in a single WHERE vm_id IN (...) query before the loops. - Add listDetailsKeyPairs(List<Long>, List<String>) to ResourceDetailsDao/DaoBase - Extract VM_DETAIL_KEYS_FOR_CAPACITY constant, add batchGetVmDetailsForCapacityCalculation - Replace per-VM getVmDetailsForCapacityCalculation with map lookup in both loops - Add test for mixed static/dynamic offerings verifying batch path and capacity math
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13410 +/- ##
============================================
+ Coverage 17.67% 17.69% +0.01%
- Complexity 15792 15799 +7
============================================
Files 5922 5922
Lines 533167 533201 +34
Branches 65210 65216 +6
============================================
+ Hits 94246 94339 +93
+ Misses 428276 428187 -89
- Partials 10645 10675 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updateCapacityForHostcalledlistDetailsKeyPairsper VM (50-100+ round-trips per host). Now batch-loads all VM details in a single WHERE vm_id IN (...) query before the loops.listDetailsKeyPairs(List<Long>, List<String>)toResourceDetailsDao/DaoBaseVM_DETAIL_KEYS_FOR_CAPACITYconstant, addbatchGetVmDetailsForCapacityCalculationgetVmDetailsForCapacityCalculationwith map lookup in both loopsTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?