Custom login base domain using GUI whitelabel themes#13412
Open
hsato03 wants to merge 1 commit into
Open
Conversation
Member
Author
|
@blueorangutan package |
|
@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13412 +/- ##
============================================
- Coverage 18.77% 18.77% -0.01%
- Complexity 17989 17990 +1
============================================
Files 6163 6163
Lines 552779 552813 +34
Branches 67365 67366 +1
============================================
- Hits 103780 103773 -7
- Misses 437587 437630 +43
+ Partials 11412 11410 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18245 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When logging in via the ACS GUI, if the user does not belong to the
ROOTdomain, its full domain path must be specified.With that, the GUI whitelabel runtime system has been extended with the
loginBaseDomainparameter, which allows administrators to specify a base domain for a theme, enabling users to log in without specifying the domain or by providing the domain relative path.For example, when creating a theme specifying the
/domain1/domain as the base, instead of the user typing/domain1/domain2when logging in, they will only need to providedomain2.Furthermore, the new parameter only works with the
commonNamesparameter.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
d1;loginBaseDomainbeingd1;d1.localURL, I verified that it was not necessary to specify the domain to access ad1account;d1account.How did you try to break this feature and the system with this change?