Add support for custom UI labels to the GUI whitelabel runtime system#13415
Open
hsato03 wants to merge 1 commit into
Open
Add support for custom UI labels to the GUI whitelabel runtime system#13415hsato03 wants to merge 1 commit into
hsato03 wants to merge 1 commit into
Conversation
Member
Author
|
@blueorangutan package |
|
@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13415 +/- ##
============================================
- Coverage 18.77% 18.76% -0.02%
+ Complexity 17989 17984 -5
============================================
Files 6163 6163
Lines 552779 552824 +45
Branches 67365 67366 +1
============================================
- Hits 103780 103733 -47
- Misses 437587 437690 +103
+ Partials 11412 11401 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GUI whitelabel management system has been extended with the
customLabelsPathparameter to allow customization of UI labels. This parameter accepts the path to a directory containing the label files, which must be named according to their language code (e.g.,en.jsonfor English).If files are stored directly on the Management Servers, the base path is
/usr/share/cloudstack-management/webapp/, so only the relative path needs to be specified. Alternatively, a full URL to the directory hosting the JSON files can be provided.Note: The path or URL where the custom language files are located must be accessible by the user.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
en.jsonfile in the/usr/share/cloudstack-management/webapp/locales/custom_labelsdirectory with the following content:{ "label.name": "Nome custom" }I created the theme specifying the directory where the
en.jsonfile was created:Navigating through the ACS GUI, I verified that the label was correctly applied:
http://192.168.103.1:8001/custom-labels/:In this endpoint, there was an
en.jsonfile with the following content:{ "label.name": "Server name", "label.state": "Server state" }Navigating through the ACS GUI, I verified that the labels were also applied:
How did you try to break this feature and the system with this change?