Repository navigation
Update ECJ versions and generate the SWAP fixture with BCEL - #537
Merged
Merged
Conversation
Update ECJ versions and generate the SWAP fixture with BCEL Default ecj.version to 3.46.100. Add property-only Maven profiles selecting 3.33.0 on Java 11 and below and 3.26.0 on Java 8 and below, with the Java 8 profile taking precedence when both activate. Replace Java 1.4 compilation in VerifierMainTest with BCEL-generated bytecode containing a SWAP instruction. Current ECJ releases reject the old source level, leaving the expected class file missing. Remove the unused SWAP.java fixture. Run the verifier subprocess with the current Java runtime and prepend the temporary fixture directory to its classpath. Retain assertions for successful verification and exactly one SWAP instruction, and dispose of instruction lists after use.
garydgregory
added a commit
that referenced
this pull request
Oct 18, 2026
Update changes.xml with detailed entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ECJ versions and generate the SWAP fixture with BCEL.
Default ecj.version to 3.46.100. Add property-only Maven profiles selecting 3.33.0 on Java 11 and below and 3.26.0 on Java 8 and below, with the Java 8 profile taking precedence when both activate.
Replace Java 1.4 compilation in VerifierMainTest with BCEL-generated bytecode containing a SWAP instruction. Current ECJ releases reject the old source level, leaving the expected class file missing. Remove the unused SWAP.java fixture.
Run the verifier subprocess with the current Java runtime and prepend the temporary fixture directory to its classpath. Retain assertions for successful verification and exactly one SWAP instruction, and dispose of instruction lists after use.
mvn; that'smvnon the command line by itself.