Skip to content

Skip JaCoCo on the Java 28-ea build - #538

Closed
nbauma109 wants to merge 1 commit into
apache:masterfrom
nbauma109:fix-ci-java-28-ea
Closed

nbauma109 wants to merge 1 commit into
apache:masterfrom
nbauma109:fix-ci-java-28-ea

Conversation

@nbauma109

Copy link
Copy Markdown
Contributor

The experimental 28-ea job of the Java CI matrix fails in BCELifierTest.testJavapCompare and BCELifierTest.testStackMap (10 failures), for instance this run.

Cause

The JaCoCo agent cannot instrument the class files of Java 28:

java.io.IOException: Error while instrumenting com/sun/tools/attach/VirtualMachine with JaCoCo 0.8.15.202606040825/6c5260a.
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 72

The tests that run javap or load JDK classes in a child JVM with the agent print this exception, and compare it with the expected output.

Change

The 28-ea matrix entry passes -Djacoco.skip=true, through a maven-args matrix variable that the other entries leave undefined (empty). The coverage is still measured by the other jobs.

Verification

mvn clean test -Djacoco.skip=true on Java 17: 3153 tests, 0 failures. The 28-ea job is the only one affected; its result will show on this pull request.

🤖 Generated with Claude Code

JaCoCo 0.8.15 fails to instrument the JDK classes of Java 28 (Unsupported class
file major version 72), which fails the experimental build (28-ea) in
BCELifierTest.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@nbauma109

Copy link
Copy Markdown
Contributor Author

@garydgregory The 28-ea job of the Java CI matrix has been failing on master since JaCoCo 0.8.15 cannot instrument Java 28 class files (Unsupported class file major version 72); the failures are the 10 cases of BCELifierTest.testJavapCompare and testStackMap, whose child JVM prints that exception.

This pull request skips JaCoCo for that matrix entry only. On my fork the same change makes all 22 checks pass, including 28-ea: nbauma109#104

Pull request #539 does not touch the workflow: its 28-ea job fails for the same reason, and passes once this change is merged and #539 is rebased onto master.

@garydgregory

Copy link
Copy Markdown
Member

Closing: it's ok for it to fail, that's why it's marked as experimental; it also serves as a canary for issues we can report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants